Skip to content

promql: info function: fix series without identifying labels not being returned#17898

Merged
aknuds1 merged 2 commits intoprometheus:mainfrom
zenador:info-func-new-unit-tests-keep-missing
Jan 20, 2026
Merged

promql: info function: fix series without identifying labels not being returned#17898
aknuds1 merged 2 commits intoprometheus:mainfrom
zenador:info-func-new-unit-tests-keep-missing

Conversation

@zenador
Copy link
Contributor

@zenador zenador commented Jan 20, 2026

Added unit tests to cover a buggy edge case, and a bug fix from @aknuds1

Which issue(s) does the PR fix:

N/A

Does this PR introduce a user-facing change?

[BUGFIX] promql: info function: fix series without identifying labels not being returned

… in the series looked up

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
@aknuds1 aknuds1 self-requested a review January 20, 2026 12:53
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
@zenador zenador force-pushed the info-func-new-unit-tests-keep-missing branch from 6a4d8bd to b4b5d20 Compare January 20, 2026 13:22
@zenador zenador changed the title promql: info function: add unit tests for when identifying labels are missing in the series looked up promql: info function: fix series without identifying labels not being returned Jan 20, 2026
@zenador zenador marked this pull request as ready for review January 20, 2026 13:26
@zenador zenador requested a review from roidelapluie as a code owner January 20, 2026 13:26
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding the bug!

@aknuds1 aknuds1 merged commit e3b6eee into prometheus:main Jan 20, 2026
52 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants