tsdb/index: export sentinel errors for size limit failures#17773
Merged
aknuds1 merged 2 commits intoprometheus:mainfrom Jan 6, 2026
Merged
tsdb/index: export sentinel errors for size limit failures#17773aknuds1 merged 2 commits intoprometheus:mainfrom
aknuds1 merged 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Patryk Prus <p@trykpr.us>
a13ce01 to
ec8c268
Compare
aknuds1
reviewed
Jan 4, 2026
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Patryk Prus <p@trykpr.us>
aknuds1
approved these changes
Jan 5, 2026
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
Looks like a nice improvement, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to detect and handle some unrecoverable TSDB errors, but don't want to rely on string matching the error message. This PR replaces the error strings with
errorvalues that can be detected usingerrors.Is.I don't think this change needs a CHANGELOG, as the change isn't user-facing.
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?