fix(remote)[v3.8]: stop PRW1 receiver from emitting bad PRW2 response headers#17683
Merged
bwplotka merged 2 commits intorelease-3.8from Dec 15, 2025
Merged
fix(remote)[v3.8]: stop PRW1 receiver from emitting bad PRW2 response headers#17683bwplotka merged 2 commits intorelease-3.8from
bwplotka merged 2 commits intorelease-3.8from
Conversation
…tats Signed-off-by: bwplotka <bwplotka@gmail.com>
krajorama
reviewed
Dec 15, 2025
… headers Signed-off-by: bwplotka <bwplotka@gmail.com>
3baf9f5 to
da253bd
Compare
Member
Author
|
Ignoring OSS fuzzing failure due to #17693 |
This was referenced Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adopting new client_golang remote lib for RW handler we made a bug where we don't provide a correct
WriteResponseStatsin theStorehandler abstraction for PRW1. This caused remote write handler to sendX-Prometheus-Remote-Write-Samples-Written 0PRWv2 response headers claiming no samples were processed.Prometheus RW sender part then interprets that as partial error, so emits scary error log and reports incorrect metrics. Sharding might have been impacted too as they depend on this data.
This affected many users #17659
Kudos to @kgeckhart who narrowed the root cause down #17659 (comment) ❤️
The fix for now is to NOT send response headers for PRWv1 flow, but the long term fix would be likely to change the client_golang remote lib Store API to be safer (explicit confirm).
This PR:
cc @pipiland2612
Which issue(s) does the PR fix:
Fixes #17659
Does this PR introduce a user-facing change?