refactor(tsdb/agent)[PART3]: add AppenderV2 support to agent#17677
Merged
refactor(tsdb/agent)[PART3]: add AppenderV2 support to agent#17677
Conversation
96063c5 to
276f391
Compare
bwplotka
commented
Dec 12, 2025
…oint Signed-off-by: bwplotka <bwplotka@gmail.com>
276f391 to
db429a5
Compare
22 tasks
ywwg
reviewed
Dec 12, 2025
Member
ywwg
left a comment
There was a problem hiding this comment.
just a little nit to start. I am still learning all of this code and what the v2 changes are bringing.
Signed-off-by: bwplotka <bwplotka@gmail.com>
db429a5 to
ad367b5
Compare
kgeckhart
reviewed
Dec 15, 2025
Contributor
kgeckhart
left a comment
There was a problem hiding this comment.
Ran out of time before I could review the tests but it's looking good!
krajorama
reviewed
Dec 16, 2025
Member
krajorama
left a comment
There was a problem hiding this comment.
looks good, couple of comments
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Member
|
I suspect this caused a crash. How did you test it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #17632
This PR is an equivalent of #17629 but for agent TSDB. I also clarify some wording on interface for clear expectations.
Again, majority of LOC comes from the duplicate tests for AppenderV2. See commit-by-commit to see what I changed in tests vs
db_test.go.cc @kgeckhart
Does this PR introduce a user-facing change?