refactor(appenderV2)[FINAL PREVIEW]: move to simpler and unified storage.AppenderV2 interface#17610
Closed
refactor(appenderV2)[FINAL PREVIEW]: move to simpler and unified storage.AppenderV2 interface#17610
Conversation
01c3a9d to
5246fad
Compare
bwplotka
commented
Nov 25, 2025
Member
Author
bwplotka
left a comment
There was a problem hiding this comment.
Some comments after 1:1 with @krajorama
TL;DR (idea so far)
- TSDB implementation now only implements AppenderV2
- Scrape package supports both implementations (AppenderV2 and Appender). The rationale are to have less things to change to downstream (e.g. Otel does not need to do anything right now, they can change to AppenderV2 later (happy to prepare preview)).
- Rest: I need to finish this PR to learn if there's anything else to descope/support both flows. We can then have test PRs that upgrades Prom on Thanos, Mimir, Cortex to see if there's anything else we can do to support ecosystem.
This was referenced Nov 25, 2025
ad43b42 to
75d901d
Compare
ecaa248 to
15ddaf5
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
… (starting point) Signed-off-by: bwplotka <bwplotka@gmail.com>
…ting point) Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com> tmp Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
15ddaf5 to
652ea55
Compare
3e22da5 to
a1d088e
Compare
22 tasks
9a7fc9e to
96308f4
Compare
5d05dcf to
e7e4509
Compare
Member
|
I would like to see scrape and prometheus continuing to support v1. It seems like OTLP would be benefitting most from the v2 appender right now. We could have helpers to help with v1-v2 if that is needed, but the changes in some areas like scrape seem really high. We could move everything to v2 appender in Prometheus v4, once we are confident it is better. It will lower the technical debt. |
Member
Author
|
Closing as things changed a lot since then. I tried to address your feedback @roidelapluie in #17632 (comment), let's continue the discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements M1 from #17632
I am slowly splitting this into smaller PRs, updating #17632 on the way.
This PR is chained on:
Otherwise in this PR:
LimitedAppenderV1in this PR. If they cannot (e.g. because metadata is updated), we switch toAppendableV2/AppenderV2straight away.Descoped (next PRs)
LimitedAppenderV1uses in Prometheus to AppenderV2.scrape.Managerappender v1 flow once Otel switched.Does this PR introduce a user-facing change?