[REFACTOR] Relabel: Remove unnecessary Process() function#17531
Merged
bboreham merged 1 commit intoprometheus:mainfrom Feb 10, 2026
Merged
[REFACTOR] Relabel: Remove unnecessary Process() function#17531bboreham merged 1 commit intoprometheus:mainfrom
bboreham merged 1 commit intoprometheus:mainfrom
Conversation
b142b00 to
fb0d740
Compare
fb0d740 to
98c5bec
Compare
All uses can be replaced by ProcessBuilder, which is more efficient. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
98c5bec to
258fcbd
Compare
bwplotka
approved these changes
Feb 6, 2026
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks (also used only in tests).
LGTM!
Member
|
Failure looks relevant (: 
|
Member
Author
|
I didn't change any code in remote-write. Re-running the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All uses can be replaced by ProcessBuilder, which is more efficient because we can reuse the
Builder.(Now that #17530 is merged)
This might give mild disruption do downstream users, but I think the fix is easy to apply.
Does this PR introduce a user-facing change?