discovery: fix constructor arguments in aws discovery#17526
Merged
aknuds1 merged 1 commit intoprometheus:mainfrom Nov 13, 2025
Merged
discovery: fix constructor arguments in aws discovery#17526aknuds1 merged 1 commit intoprometheus:mainfrom
aknuds1 merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Julius Hinze <julius.hinze@grafana.com>
Contributor
|
thanks! was just PRing this myself, appreciate it |
Contributor
|
this PR also fixes the ECS parameters but I can ask for review separately #17527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was broken by a collision between #17406 and #17138 which were both tested independently.
Does this PR introduce a user-facing change?