Skip to content

feat: rename CreatedTimestamp to StartTimestamp#17523

Merged
bwplotka merged 1 commit intomainfrom
ct-st-rename
Nov 13, 2025
Merged

feat: rename CreatedTimestamp to StartTimestamp#17523
bwplotka merged 1 commit intomainfrom
ct-st-rename

Conversation

@bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 13, 2025 •
edited
Loading

Partially fixes #17416 by renaming all CT* names to ST* in the whole codebase except protos:

  • RW2 (this is done in separate PR)
  • PrometheusProto exposition proto (not sure if we want to change this)
CreatedTimestamp -> StartTimestamp
CreatedTimeStamp -> StartTimestamp
created_timestamp -> start_timestamp
CT -> ST
ct -> st

Does this PR introduce a user-facing change?

NONE

@bwplotka bwplotka force-pushed the ct-st-rename branch 2 times, most recently from 3ef5680 to c5c6783 Compare November 13, 2025 09:15
@bwplotka bwplotka mentioned this pull request Nov 13, 2025
Merged
@bwplotka bwplotka force-pushed the ct-st-rename branch 4 times, most recently from 964f963 to 195c225 Compare November 13, 2025 09:23
@bwplotka bwplotka marked this pull request as ready for review November 13, 2025 09:23
@bwplotka bwplotka requested a review from ArthurSens November 13, 2025 09:23
@bwplotka bwplotka force-pushed the ct-st-rename branch 3 times, most recently from f00d829 to 7b39f59 Compare November 13, 2025 12:53
@bwplotka
feat: rename CreatedTimestamp to StartTimestamp
b46c78c 
Partially fixes #17416 by
renaming all CT* names to ST* in the whole codebase except RW2 (this is
done in separate
[PR](#17411)) and
PrometheusProto exposition proto.

```
CreatedTimestamp -> StartTimestamp
CreatedTimeStamp -> StartTimestamp
created_timestamp -> start_timestamp
CT -> ST
ct -> st

```

Signed-off-by: bwplotka <bwplotka@gmail.com>
ArthurSens
ArthurSens approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this must have been an exhausting PR 😅

@bwplotka
Copy link
Member Author

bwplotka commented Nov 13, 2025

Nah, it was fun.

It could be efficient if wrote a single replace regex, instead I was playing with few e.g. ([ .\(])ct([ A-Z\),:) -> $1st$2

@bwplotka bwplotka enabled auto-merge (squash) November 13, 2025 13:36
@bwplotka
Copy link
Member Author

bwplotka commented Nov 13, 2025

Merging given only one test failure from the knowingly flaky test: --- FAIL: TestRemoteWrite_ReshardingWithoutDeadlock (30.60s)

@bwplotka bwplotka disabled auto-merge November 13, 2025 14:17
@bwplotka bwplotka merged commit f50ff0a into main Nov 13, 2025
79 of 82 checks passed
@bwplotka bwplotka deleted the ct-st-rename branch November 13, 2025 14:17
@bwplotka bwplotka mentioned this pull request Nov 14, 2025
Open
7 tasks
@swiatekm swiatekm mentioned this pull request Jan 28, 2026
Merged
This was referenced Jan 28, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

@aknuds1 aknuds1 Awaiting requested review from aknuds1 aknuds1 is a code owner

@cstyan cstyan Awaiting requested review from cstyan cstyan is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename CreatedTimestamp (CT) to StartTimestamp (ST)

2 participants

@bwplotka @ArthurSens