promtool: Add Remote Write 2.0 support to push metrics command#17417
Merged
bwplotka merged 7 commits intoprometheus:mainfrom Oct 31, 2025
Merged
promtool: Add Remote Write 2.0 support to push metrics command#17417bwplotka merged 7 commits intoprometheus:mainfrom
bwplotka merged 7 commits intoprometheus:mainfrom
Conversation
6bed7a6 to
df8a907
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
bwplotka
reviewed
Oct 29, 2025
bwplotka
requested changes
Oct 29, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Great! Looks good, just I'd be consistent with Prometheus config, even if a bit verbose. WDYT?
91bfde6 to
ab57e4a
Compare
Contributor
Author
|
Hi, thanks for suggesting. PTAL again I have solved it. |
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
bwplotka
approved these changes
Oct 31, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
One nit, but we can merge without it. Release note has to change though, but I can updated it myself, unless you want to do it (it references wrong flag)
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?