OTLP: de-duplicate target_info samples with conflicting timestamps#17400
Merged
aknuds1 merged 3 commits intoprometheus:mainfrom Oct 28, 2025
Merged
OTLP: de-duplicate target_info samples with conflicting timestamps#17400aknuds1 merged 3 commits intoprometheus:mainfrom
aknuds1 merged 3 commits intoprometheus:mainfrom
Conversation
3314d39 to
8294842
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
8294842 to
68f7733
Compare
b214bd6 to
f898cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
The PR adds logic to the
target_infometric generation in the OTLP endpoint, so that any samples with the same timestamp for the same (target_info) series are de-duplicated. It comes out of a user's bug report about duplicatedtarget_infosamples in Grafana Mimir (which uses the Prometheustarget_infogeneration logic).If I'm not mistaken, duplicate
target_infosamples should stem from multiple resources in the same OTLP request being translated to the sametarget_infolabel set. It shouldn't be caused by a Prometheus bug.Does this PR introduce a user-facing change?