Include histograms in sample_limit logic#17390
Merged
beorn7 merged 2 commits intoprometheus:mainfrom Oct 24, 2025
Merged
Conversation
Currently histograms bypass sample_limit logic as the limitAppender only implements the Append() method, while histograms are appended using AppendHistogram. This means that they are effectively ignored during sample_limit checks and a scrape with sample_limit=100 and 500 histograms will accept all samples. Add AppendHistogram method to the limitAppender so histograms are also counted towards sample_limit. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
TestScrapeLoop_HistogramBucketLimit tests the bucket limiter but it also sets sample_limit to the same value, which seems incorrect. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
fd3cb4d to
aac472d
Compare
beorn7
approved these changes
Oct 24, 2025
Member
|
Thanks again. 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently histograms bypass sample_limit logic as the limitAppender only implements the Append() method, while histograms are appended using AppendHistogram. This means that they are effectively ignored during sample_limit checks and a scrape with sample_limit=100 and 500 histograms will accept all samples. Add AppendHistogram method to the limitAppender so histograms are also counted towards sample_limit.
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?