Skip to content

[RW2] Fix type and unit labels propagation in Remote Write v2 receiver to prioritize type-and-unit-labels feature#17387

Merged
bwplotka merged 3 commits intoprometheus:mainfrom
pipiland2612:type_unit_agent
Oct 31, 2025
Merged

[RW2] Fix type and unit labels propagation in Remote Write v2 receiver to prioritize type-and-unit-labels feature#17387
bwplotka merged 3 commits intoprometheus:mainfrom
pipiland2612:type_unit_agent

Conversation

@pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Oct 22, 2025 •
edited
Loading

Which issue(s) does the PR fix:

Does this PR introduce a user-facing change?

[BUGFIX] Remote-write: Type and unit labels are now correctly propagated when receiving metrics via Remote Write v2 with the `type-and-unit-labels` feature flag enabled.

@pipiland2612
fix
35f4aec 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Oct 22, 2025

cc @bwplotka

bwplotka
bwplotka requested changes Oct 27, 2025
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a readability nits, especially on the scope of this change. It's not ONLY fixing agent mode, but for all modes if the metadata is passed via metadata-wal-records feature or any other mechanism WHILE type and unit labels are also preserved.

NOTE: This means also that type-and-unit feature overrides metadata records. This should not matter, because we often take them from the same place on scrape, but due to bugs in scraping etc this could matter, so maybe we could mention this in our feature flags docs?

@pipiland2612
fix nits & update docs
debeff3 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Oct 27, 2025

Hi @bwplotka, thanks for reviewing. PTAL debeff3. I have updated the docs and fix the test name and comments.

bwplotka
bwplotka approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some suggestion to docs; also please change PR title, and description (e.g. changelog) to mention it's not only agent mode please.

@pipiland2612 pipiland2612 changed the title [RW2] Fix Type and Units labels to correctly work on agent mode [RW2] Fix type and unit labels propagation in Remote Write v2 receiver to prioritize type-and-unit-labels Oct 28, 2025
@pipiland2612 pipiland2612 changed the title [RW2] Fix type and unit labels propagation in Remote Write v2 receiver to prioritize type-and-unit-labels [RW2] Fix type and unit labels propagation in Remote Write v2 receiver to prioritize type-and-unit-labels feature Oct 28, 2025
@pipiland2612
fix docs
248ddd8 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Oct 28, 2025

Hi @bwplotka, thanks for noticing me. I have updated the PR description, title and change the docs at 248ddd8. PTAL. Thanks!

@pipiland2612 pipiland2612 reopened this Oct 28, 2025
@pipiland2612 pipiland2612 reopened this Oct 28, 2025
bwplotka
bwplotka approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit c8f1de1 into prometheus:main Oct 31, 2025
68 of 70 checks passed
@pipiland2612 pipiland2612 deleted the type_unit_agent branch October 31, 2025 09:04
@grizzlybite grizzlybite mentioned this pull request Nov 5, 2025
Closed
@bwplotka bwplotka mentioned this pull request Dec 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwplotka bwplotka bwplotka approved these changes

@cstyan cstyan Awaiting requested review from cstyan cstyan is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RW2] Type and unit labels not applied when using Prometheus Agent

2 participants

@pipiland2612 @bwplotka