discovery/aws: Fix region load from IMDS#17376
Merged
krajorama merged 3 commits intoprometheus:release-3.7from Oct 22, 2025
Merged
discovery/aws: Fix region load from IMDS#17376krajorama merged 3 commits intoprometheus:release-3.7from
krajorama merged 3 commits intoprometheus:release-3.7from
Conversation
Loading the local region from the Instance MetaData Service broke in v3.7. This adds the IMDS call back in order to load the local region when no other method has set the region. fixes prometheus#17375 Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
Member
|
Do we need this for lightsail too ? |
Signed-off-by: Joe Adams <github@joeadams.io>
Contributor
Author
|
@roidelapluie Thanks for pointing that out. I didn't think that lightsail had IMDS but your question prompted me to investigate and it turns out it does. |
Contributor
Author
|
Are the windows tests flaky? I had to rerun them. |
roidelapluie
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading the local region from the Instance MetaData Service broke in v3.7. This adds the IMDS call back in order to load the local region when no other method has set the region.
Which issue(s) does the PR fix:
Fixes #17375
Does this PR introduce a user-facing change?
NONE