Skip to content

fix(react-app): correct createExpressionLink query for /graph links#17365

Merged
juliusv merged 1 commit intoprometheus:mainfrom
akshatsinha0:fix/old-ui-createExpressionLink
Oct 19, 2025
Merged

fix(react-app): correct createExpressionLink query for /graph links#17365
juliusv merged 1 commit intoprometheus:mainfrom
akshatsinha0:fix/old-ui-createExpressionLink

Conversation

@akshatsinha0
Copy link
Contributor

Fixes broken /graph links generated by old UI’s createExpressionLink, restoring navigation from Alerts/Rules pages by separating params and removing a stray trailing dot.

Which issue(s) does the PR fix:

Does this PR introduce a user-facing change?

[BUGFIX] Old UI: Fix createExpressionLink to correctly build /graph URLs so links from Alerts/Rules work again

 Ensure params are joined with & and remove trailing dot to restore working links from Alerts/Rules to Graph.

Signed-off-by: Akshat Sinha <akshatsinhasramhardy@gmail.com>
@akshatsinha0 akshatsinha0 requested a review from juliusv as a code owner October 18, 2025 22:42
@juliusv
Copy link
Member

juliusv commented Oct 19, 2025

Thanks! And wow, I guess this must've been broken since 4 years since #8832

@juliusv juliusv merged commit 4c1355e into prometheus:main Oct 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants