Skip to content

UI: Add smoothed/anchored in explain#17334

Merged
juliusv merged 1 commit intoprometheus:mainfrom
roidelapluie:roidelapluie/explain
Oct 27, 2025
Merged

UI: Add smoothed/anchored in explain#17334
juliusv merged 1 commit intoprometheus:mainfrom
roidelapluie:roidelapluie/explain

Conversation

@roidelapluie
Copy link
Member

@roidelapluie roidelapluie commented Oct 15, 2025

you can build this on top of #17239 for optimal experience

[ENHANCEMENT] UI: Add smoothed/anchored in explain

Copy link
Member

@juliusv juliusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just one comment.

Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM from me, too, modulo @juliusv's comment.

@roidelapluie
Copy link
Member Author

Updated

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
@roidelapluie
Copy link
Member Author

roidelapluie commented Oct 20, 2025

@juliusv I needed to update quite a few things by making the fields non-optional, so I guess another review is welcome.

@juliusv
Copy link
Member

juliusv commented Oct 27, 2025

Thanks 👍

@juliusv juliusv merged commit dca3289 into prometheus:main Oct 27, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants