Optimize scrape target by using RLock in read methods#17306
Merged
machine424 merged 1 commit intoprometheus:mainfrom Oct 8, 2025
Merged
Optimize scrape target by using RLock in read methods#17306machine424 merged 1 commit intoprometheus:mainfrom
machine424 merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Ali Nazari <ali4nazari4@gmail.com>
bd1f2db to
f64ee61
Compare
Contributor
Author
|
@machine424, PR is ready for review whenever you have time. Thanks. |
machine424
approved these changes
Oct 8, 2025
Member
machine424
left a comment
There was a problem hiding this comment.
lgtm, thanks for this!
For the release note, to make it clearer for end users, I’d suggest:
"[BUGFIX] API: Reduce lock contention on /api/v1/targets"
(I wouldn’t tag it as [PERF] or [ENHANCEMENT], since we don’t have numbers to back that up (it'll not be easy to benchmark this), let's consider it as a bug fix)
Contributor
Author
|
Thanks! Updated the release note as suggested. |
Contributor
Author
|
@machine424, by the way, will you handle the merge, or should I wait for someone else to do it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Fixes #16549
Does this PR introduce a user-facing change?