NHCB: Reject custom bucket bounds with NaN value#17287
Merged
krajorama merged 1 commit intoprometheus:mainfrom Oct 6, 2025
Merged
NHCB: Reject custom bucket bounds with NaN value#17287krajorama merged 1 commit intoprometheus:mainfrom
krajorama merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
vpranckaitis
approved these changes
Oct 6, 2025
krajorama
approved these changes
Oct 6, 2025
Member
krajorama
left a comment
There was a problem hiding this comment.
LGTM. NaN as an upper boundary makes little sense and also https://prometheus.io/docs/specs/om/open_metrics_spec/#metric-types says "Bucket thresholds MUST NOT equal NaN." I'd be interested in a use case where people do use NaN for some reason :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no way for a
NaNto be usable as a valid Native Histogram Custom Bound value.Added a validation check to prevent such values. Also, added a couple more related validation test cases.
Does this PR introduce a user-facing change?