Conversation
… set Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Member
Author
|
if possible, it would be great to include this PR in the current release so we can provide this change in Thanos. |
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Member
Author
|
ping @juliusv in case it went out of your radar :) Let me know if you need further explanation ! |
juliusv
approved these changes
Oct 27, 2025
Member
juliusv
left a comment
There was a problem hiding this comment.
Whoops, never got to this PR, sorry! Sounds good though 😊👍
Seems like the release notes CI check needs to be fixed?
This was referenced Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is changing the way the Typescript Prometheus client is working.
This client is used afterward in the PromQL autocompletion.
Before, when getting the label names and values, we were setting a time interval to 12 hours. In a big Prometheus or in huge Thanos cluster, this query can be costly and most of the time not necessary for the autocompletion, specially when calling the endpoint
/api/v1/seriesAlso the code that autocomplete label values or labels names when associated to a metric name is calling the endpoint
/api/v1/seriescausing OOMKilled when big Prometheus or Thanos cluster are involved.For example, autocomplete a label values associated to a metric name is currently crashing Thanos querier in Amadeus (and they are running with 60 GB of memory)
With this PR, if the interval is not explicitly defined, then the autocompletion will get the label values and label names without setting a time interval, relying on the default server configuration instead.
It will also always call the endpoint
api/v1/labelsor/api/v1/label/<label_name>with the parametermatcherto get the label names and values associated to a metric.This change should improve the performance of the autocompletion.
For the context, this provides a way to tackle this issue: thanos-io/thanos#4685