[BUGFIX] PromQL: fix slice indexing bug in info function#17135
Merged
aknuds1 merged 4 commits intoprometheus:mainfrom Sep 5, 2025
Merged
[BUGFIX] PromQL: fix slice indexing bug in info function#17135aknuds1 merged 4 commits intoprometheus:mainfrom
aknuds1 merged 4 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
aknuds1
reviewed
Sep 5, 2025
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
Nice fix! Would you mind applying my suggestions?
Also: Not a blocker, but I think a bugfix changelog entry would be nice.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>
Contributor
Author
Thanks for a quick review! Accepted both suggestions and added a changelog item. |
Contributor
Thanks! Did you forget to push the changelog change though? |
4751693 to
ef051c3
Compare
Contributor
Author
My bad, I though this was about the entry in PR description. Pushed CHANGELOG.md change now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Fixes #17134.
Slice indices were being used for matching between data and info series, but those indices are not stable - they may change from step to step in the presence of time series churn. Replaced indices with hashes for robust matching instead.
Also added more details to the error message to make diagnosing issues like this easier when using the function at scale.
Does this PR introduce a user-facing change?