Conversation
4d23c84 to
c976b32
Compare
|
Hi, thanks for this. Are you volunteering to maintain this code long-term? |
|
Hi, yes I'm willing to maintain this long term. |
c976b32 to
4a846fb
Compare
|
Exciting 🙂 |
ec235c3 to
fa007b9
Compare
|
Any news on this PR review? I can also help to maintain this code long-term if needed 🙏 |
|
I still think we should refactor the AWS discovery into a single Something like: - job_name: ecs
aws_sd_configs:
role: ecs
region: us-east-1
... |
|
Yeh that might be a good option to consolidate all of the AWS service discovery options into 1. Also if something new came up in the future we could add more to it quite easily. I'll look at refactoring if this is the preferred direction. |
|
Yes, that would be great if you're willing to work on it. I would love to see additional roles like rds and elasticache discovery. We currently manually manage a bunch of scrape configs to use the postgres and redis exporters. It would be great to be able to use built-in discovery. |
|
Cool, I'll make this a more generic AWS SD that we can add more services to as and when (MSK would benefit me as well now that I think about it). I'll probably put this in a different PR as well as I think the scope has outgrown this one a bit. |
518658e to
68841a7
Compare
Signed-off-by: matt-gp <small_minority@hotmail.com>
68841a7 to
4b65f1f
Compare
|
Raised 17406 |
Hi all,
This PR adds service discovery support for AWS Elastic Container Services. Previous discussions for adding this were nearly 4 years ago here 9310. A previous pr was also created 15856 and this is loosely based on this.
Currently if users want service discovery for ECS they have to use a separate service which implements the http service discovery, and query that. ECS is quite a popular way of running containers without having to manage infrastructure so I feel this would be a good addition.
In terms of rate limiting, the request concurrency by default is set to 20 req/sec which aligns with describe/list requests listed https://docs.aws.amazon.com/AmazonECS/latest/APIReference/request-throttling.html.
Tests are also included and I've been testing locally.
Feedback welcome
Does this PR introduce a user-facing change?