Merged
Conversation
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>
codesome
reviewed
Aug 26, 2025
Member
codesome
left a comment
There was a problem hiding this comment.
I will let the release shepherd take a call on this one
Add changelog entry to pull in #16925 to v3.6.0. Signed-off-by: SuperQ <superq@gmail.com>
1f4e422 to
b1802ba
Compare
Member
|
/prombench v3.6.0-rc.0 |
Contributor
|
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
Member
|
/prombench cancel |
Contributor
|
Benchmark cancel is in progress. |
Member
|
#17101 (comment) revealed some diffs in lock contention go_sync_mutex_wait_total_seconds_total |
Member
|
the prombench is normal. |
machine424
approved these changes
Sep 9, 2025
Member
machine424
left a comment
There was a problem hiding this comment.
given this was already merged on main, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Pick #16925 into v3.6.0
Does this PR introduce a user-facing change?