fix(tsdb): appender does not honor append order#16823
Closed
fix(tsdb): appender does not honor append order#16823
Conversation
Fixes: #15177 Instead of 3 separate lists, keep a single list of samples with series reference. To support different data types I did a union type where floats are handled separately from complex types, but complex types are kept in one place. Not finished, in particular the WAL format is kept and there's a conversion from the union type to separate record types for the WAL/WBL. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
17b70cf to
7876c57
Compare
Add a testcase to the PromQL unit tests that has mixed order of floats vs native histograms. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Member
Author
|
superseded by #17071 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14172
Fixes: #15177
Instead of 3 separate lists, keep a single list of samples with series reference. To support different data types I did a union type where floats are handled separately from complex types, but complex types are kept in one place.
Not optimized, and doesn't fix that WAL/WBL that keeps 5 different value types separately: floats, integer/float native histograms with standard/custom buckets, meaning that on reload the problem comes back.
Ideas for the WAL/WBL: