textparse: CreatedTimestamp now returns int64 value; optimized proto CT parsing#16072
Merged
textparse: CreatedTimestamp now returns int64 value; optimized proto CT parsing#16072
Conversation
3d6fe0d to
0496658
Compare
bboreham
reviewed
Feb 24, 2025
Member
bboreham
left a comment
There was a problem hiding this comment.
Why do we need such a long benchmark?
Shouldn't it show up in existing benchmarks?
Member
Author
To focus on CT part. Happy to remove. |
ArthurSens
approved these changes
Mar 1, 2025
Member
ArthurSens
left a comment
There was a problem hiding this comment.
LGTM
I don't mind leaving the benchmark command as a comment, it's convenient :)
..instead of *int64. This is as an optimization and ease of use. We already accepted in many places (proto histograms, PRW) that CT (or any timestamp really) 0 means not set. Signed-off-by: bwplotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..instead of *int64. This is as an optimization and ease of use. We already accepted in many places (proto histograms, PRW) that CT (or any timestamp really) 0 means not set. I added todos for normal timestamps too.
Additionally I added trivial fast path for protobuf CreatedTimestamp implementation, was visible on allocs/s in #16046 (comment)
For proto: