test: add TestTargetsFromGroupWithLabelKeepDrop to reinforce a relabelling behaviour#15529
Merged
beorn7 merged 1 commit intoprometheus:mainfrom Dec 5, 2024
Merged
test: add TestTargetsFromGroupWithLabelKeepDrop to reinforce a relabelling behaviour#15529beorn7 merged 1 commit intoprometheus:mainfrom
beorn7 merged 1 commit intoprometheus:mainfrom
Conversation
machine424
commented
Dec 3, 2024
| name: "no relabeling", | ||
| cfgText: ` | ||
| global: | ||
| metric_name_validation_scheme: legacy |
Member
Author
There was a problem hiding this comment.
Had to add those to get around:
2024/12/03 17:19:06 http: TLS handshake error from 127.0.0.1:52972: remote error: tls: bad certificate
--- FAIL: TestTargetsFromGroupWithLabelKeepDrop (0.00s)
--- FAIL: TestTargetsFromGroupWithLabelKeepDrop/no_relabeling (0.00s)
panic: utf8 name validation requested but model.NameValidationScheme is not set to UTF8 [recovered]
panic: utf8 name validation requested but model.NameValidationScheme is not set to UTF8 [recovered]
panic: utf8 name validation requested but model.NameValidationScheme is not set to UTF8
(will look into that later, maybe we need to override a global var in this test file or sth...)
Member
Author
There was a problem hiding this comment.
opened #15530 as this is not caused/related to the change in the PR.
beorn7
previously approved these changes
Dec 4, 2024
Member
beorn7
left a comment
There was a problem hiding this comment.
With tiny spelling nit. Feel free to merge after fixing it.
…lling behaviour. fixes prometheus#12355 Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Member
Author
|
opened #15538 for the unrelated data race in tests. |
Member
|
And thanks for filing #15538 |
beorn7
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12355