Skip to content

Feature/aliyun ecs discovery#15212

Open
KeyOfSpectator wants to merge 5 commits intoprometheus:mainfrom
AliyunContainerService:feature/aliyun-ecs-discovery-20241024
Open

Feature/aliyun ecs discovery#15212
KeyOfSpectator wants to merge 5 commits intoprometheus:mainfrom
AliyunContainerService:feature/aliyun-ecs-discovery-20241024

Conversation

@KeyOfSpectator
Copy link

@KeyOfSpectator KeyOfSpectator commented Oct 24, 2024

Pressure test: this implement support pressure test with about 1K ECS instances, and every ECS have multi tags, support alternating ECS scaling scenario. PRESSURE_TEST.md
Support filter with ECS tags.
Use scrolling API to discover ecs to support frequency ECS scale change scenario.
UT and README and so on.

@KeyOfSpectator KeyOfSpectator force-pushed the feature/aliyun-ecs-discovery-20241024 branch 2 times, most recently from d313a0a to e1c8d7b Compare October 24, 2024 12:11
KeyOfSpectator and others added 5 commits October 24, 2024 20:12
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
@KeyOfSpectator KeyOfSpectator force-pushed the feature/aliyun-ecs-discovery-20241024 branch from e1c8d7b to 4f73009 Compare October 24, 2024 12:13
@KeyOfSpectator
Copy link
Author

fixes #11931

@KeyOfSpectator KeyOfSpectator marked this pull request as ready for review October 24, 2024 12:37
@KeyOfSpectator
Copy link
Author

KeyOfSpectator commented Oct 24, 2024

@roidelapluie @beorn7 hi, PTAL.

@KeyOfSpectator
Copy link
Author

KeyOfSpectator commented Oct 25, 2024

Does this pressure test report need to be placed in the code repository? PRESSURE_TEST.md

We already published it in our blog channel. prometheus aliyun ecs sd pressure test report
@roidelapluie @beorn7

@bboreham
Copy link
Member

bboreham commented Nov 5, 2024

@KeyOfSpectator please can you say something about how this code will be maintained for years into the future.

@KeyOfSpectator
Copy link
Author

@KeyOfSpectator please can you say something about how this code will be maintained for years into the future.

Hi, @bboreham @beorn7

I am from the Alibaba Cloud team, and I am responsible for AlibabaCloud's Cloud Native Observability and Kubernetes. My team is in charge of Alibaba Cloud's Prometheus service and related products. Our product development has always followed the compatibility standards set by the Prometheus community and ecosystem.

Many of our customers are also users of the native Prometheus community and have very strong requirements.

We are very willing to continue contributing to the Prometheus community and to be responsible for the ongoing evolution and iteration of relevant parts within the Prometheus community.

If there are working groups or other collaborative mechanisms in the community, please include me, and I will coordinate with my team members to follow up continuously.

@KeyOfSpectator
Copy link
Author

Hi, @bboreham @beorn7

Could you please let me know if there has been any progress?

@beorn7
Copy link
Member

beorn7 commented Nov 27, 2024

Hopefully we will discuss the more general SD topic and this issue in particular at tomorrow's dev summit.

It would also be good to hear @roidelapluie's opinion about this.

@KeyOfSpectator
Copy link
Author

Hi. @roidelapluie @beorn7 @bboreham
Could you please let me know if there has been any progress?

@beorn7
Copy link
Member

beorn7 commented Jan 8, 2025

We didn't get to the SD topic at the dev summit, sorry for that.

And still no message from @roidelapluie .

@beorn7
Copy link
Member

beorn7 commented Feb 20, 2025

Finally an update:

We talked about this during the dev-summit. My understanding is that we would most prefer to simply make you (and/or coworkers of yours) maintainers of the new discovery/aliyun subtree and grant you push permissions to it. If this looks good to you, let us know, and @gouthamve will figure out the permissions setting and put your name into place.

@KeyOfSpectator
Copy link
Author

Great to hear the news :)
No problem, please add me as a maintainer of the new discovery/aliyun subtree repository and grant me push permissions. I'll coordinate follow-up tasks with the relevant team members. Additionally, if there are any updates or new plans for the dev-summit in the future, kindly keep me in the loop.
@beorn7 @gouthamve @roidelapluie

@gouthamve
Copy link
Member

Hey @KeyOfSpectator, really sorry for the delay here. This is a high priority for me, and I'm aiming to put out a doc on how to give permissions in a way that scales by the end of this week. If it looks like the solution is complicated, I'll also propose a short-term interim solution to unblock you.

Overall, I'm planning to give you the required permissions by the end of next week. Thank you for the contribution, and I'm requesting a little bit more of your patience as I work on this.

@KeyOfSpectator
Copy link
Author

Hey @KeyOfSpectator, really sorry for the delay here. This is a high priority for me, and I'm aiming to put out a doc on how to give permissions in a way that scales by the end of this week. If it looks like the solution is complicated, I'll also propose a short-term interim solution to unblock you.

Overall, I'm planning to give you the required permissions by the end of next week. Thank you for the contribution, and I'm requesting a little bit more of your patience as I work on this.

Thx a lot, please take your time.
Ping me when you ready.

@KeyOfSpectator
Copy link
Author

Hey @KeyOfSpectator, really sorry for the delay here. This is a high priority for me, and I'm aiming to put out a doc on how to give permissions in a way that scales by the end of this week. If it looks like the solution is complicated, I'll also propose a short-term interim solution to unblock you.

Overall, I'm planning to give you the required permissions by the end of next week. Thank you for the contribution, and I'm requesting a little bit more of your patience as I work on this.

@gouthamve Hi, if there is any progress, please let me know~ :D

@krajorama
Copy link
Member

Hello from the bug scrub!

Pinging @gouthamve for an update on governance aspect.

@KeyOfSpectator
Copy link
Author

@gouthamve
Hello, please let me know if there is any progress. Our customers have strong demands for this feature.

@github-actions github-actions bot added the stale label Nov 3, 2025
@krajorama krajorama self-assigned this Nov 25, 2025
@krajorama
Copy link
Member

Hello from the bug scrub.

Current state is that we have CODEOWNERS file now, need to make it effective. @gouthamve let's make it happen next week and add @KeyOfSpectator as codeowner for this path.

github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.0.2 // indirect
github.com/opencontainers/runtime-spec v1.0.2 // indirect
github.com/opentracing/opentracing-go v1.2.1-0.20220228012449-10b1cf09e00b // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment: can this be updated to use OpenTelemetry?

@github-actions github-actions bot removed the stale label Nov 26, 2025
@krajorama
Copy link
Member

krajorama commented Jan 27, 2026

@KeyOfSpectator are you still interested in becoming a maintainer with approve rights? We finally put the infrastructure in place and we can make the move. Plz accept the invite the collaborate on the prometheus repo if yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants