Feature/aliyun ecs discovery#15212
Conversation
d313a0a to
e1c8d7b
Compare
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
Signed-off-by: 行疾 <shichun.fsc@alibaba-inc.com>
e1c8d7b to
4f73009
Compare
|
fixes #11931 |
|
@roidelapluie @beorn7 hi, PTAL. |
|
Does this pressure test report need to be placed in the code repository? PRESSURE_TEST.md We already published it in our blog channel. prometheus aliyun ecs sd pressure test report |
|
@KeyOfSpectator please can you say something about how this code will be maintained for years into the future. |
I am from the Alibaba Cloud team, and I am responsible for AlibabaCloud's Cloud Native Observability and Kubernetes. My team is in charge of Alibaba Cloud's Prometheus service and related products. Our product development has always followed the compatibility standards set by the Prometheus community and ecosystem. Many of our customers are also users of the native Prometheus community and have very strong requirements. We are very willing to continue contributing to the Prometheus community and to be responsible for the ongoing evolution and iteration of relevant parts within the Prometheus community. If there are working groups or other collaborative mechanisms in the community, please include me, and I will coordinate with my team members to follow up continuously. |
|
Hopefully we will discuss the more general SD topic and this issue in particular at tomorrow's dev summit. It would also be good to hear @roidelapluie's opinion about this. |
|
Hi. @roidelapluie @beorn7 @bboreham |
|
We didn't get to the SD topic at the dev summit, sorry for that. And still no message from @roidelapluie . |
|
Finally an update: We talked about this during the dev-summit. My understanding is that we would most prefer to simply make you (and/or coworkers of yours) maintainers of the new discovery/aliyun subtree and grant you push permissions to it. If this looks good to you, let us know, and @gouthamve will figure out the permissions setting and put your name into place. |
|
Great to hear the news :) |
|
Hey @KeyOfSpectator, really sorry for the delay here. This is a high priority for me, and I'm aiming to put out a doc on how to give permissions in a way that scales by the end of this week. If it looks like the solution is complicated, I'll also propose a short-term interim solution to unblock you. Overall, I'm planning to give you the required permissions by the end of next week. Thank you for the contribution, and I'm requesting a little bit more of your patience as I work on this. |
Thx a lot, please take your time. |
@gouthamve Hi, if there is any progress, please let me know~ :D |
|
Hello from the bug scrub! Pinging @gouthamve for an update on governance aspect. |
|
@gouthamve |
|
Hello from the bug scrub. Current state is that we have CODEOWNERS file now, need to make it effective. @gouthamve let's make it happen next week and add @KeyOfSpectator as codeowner for this path. |
| github.com/opencontainers/go-digest v1.0.0 // indirect | ||
| github.com/opencontainers/image-spec v1.0.2 // indirect | ||
| github.com/opencontainers/runtime-spec v1.0.2 // indirect | ||
| github.com/opentracing/opentracing-go v1.2.1-0.20220228012449-10b1cf09e00b // indirect |
There was a problem hiding this comment.
Drive-by comment: can this be updated to use OpenTelemetry?
|
@KeyOfSpectator are you still interested in becoming a maintainer with approve rights? We finally put the infrastructure in place and we can make the move. Plz accept the invite the collaborate on the prometheus repo if yes. |
Pressure test: this implement support pressure test with about 1K ECS instances, and every ECS have multi tags, support alternating ECS scaling scenario. PRESSURE_TEST.md
Support filter with ECS tags.
Use scrolling API to discover ecs to support frequency ECS scale change scenario.
UT and README and so on.