Add documentation for custom headers.#14660
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Sep 3, 2024
Merged
Conversation
bboreham
reviewed
Aug 21, 2024
docs/configuration/configuration.md
Outdated
|
|
||
| # Per-scrape limit on number of labels that will be accepted for a sample. If | ||
| # more than this number of labels are present post metric-relabeling, the | ||
| # more than this number of labels are present post metric-relabeling ], the |
Member
There was a problem hiding this comment.
Is this change intentional? I couldn't see the opening bracket.
c7bb480 to
06c9bb8
Compare
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien <roidelapluie@o11y.eu>
06c9bb8 to
ed2e18d
Compare
machine424
approved these changes
Sep 2, 2024
Member
machine424
left a comment
There was a problem hiding this comment.
Thanks!
(Not to block this PR but It'd be great to have tests for this, those would be used as a "proof" to users who may have questions/issues with headers. But also to catch any eventual regression on common side.)
If this PR is merged, I will add it to all the http configs on the page.
Why not adding them in this PR?
Member
Author
|
Let's at least have the documentation in order for scrape configs. I will create another PR for the rest of the docs and the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR is merged, I will add it to all the http configs on the page.