@machine424 can you review or ask somebody to do so? not sure who to ping here

@machine424 unfortunately convertToFloat isn't exported: https://github.com/prometheus/common/pull/627/files#diff-c8c3e840ed35e815552e86f6ef5b464d17ed5b61fe947b9c634a454c886db9a3R23
Do you think we should export it and remove it from here as well? If yes, I suggest doing it in another PR, as it'll require a PR on prometheus/common first and a version bump.

On your other comment, fixed it as well, can you review it once more?

Just to clarify, the idea seems nice. Maybe even better approach would be to remove the need of having to use convertToFloat internally in prometheus by moving all the functions that use it to common as well (given that convertToFloat isn't used outside of template funcs as far I as can see)?

What do you think? @machine424

Just to clarify, the idea seems nice. Maybe even better approach would be to remove the need of having to use convertToFloat internally in prometheus by moving all the functions that use it to common as well (given that convertToFloat isn't used outside of template funcs as far I as can see)?

I'd only move to commons, the utils that are to be used in other repos and that we are willing to share.
I know they don't change a lot, but if we can avoid having to bump commons to make a change in an util that's only used by prometheus, it'd be great.
I proposed that for convertToFloat because it's already defined in prometheus and in commons currently.

@machine424 also agree, but given that ConvertToFloat isn't used outside of templates, it's rather a helper than a template function and it kinda makes sense to move it to helpers folder or something like that (and then reuse it in both prometheus and alertmanager repos). What do you think?

@machine424 can we get this merged or is there something else to do here?

If @gotjosh, as he reviewed the commons PR, has no remarks, I'll merge.