Convert classic histograms to nhcb in scrape#14008
Closed
zenador wants to merge 18 commits intoprometheus:mainfrom
Closed
Convert classic histograms to nhcb in scrape#14008zenador wants to merge 18 commits intoprometheus:mainfrom
zenador wants to merge 18 commits intoprometheus:mainfrom
Conversation
krajorama
reviewed
Apr 30, 2024
scrape/scrape.go
Outdated
| } else { | ||
| ref, err = app.Append(ref, lset, t, val) | ||
|
|
||
| if sl.convertClassicHistograms { |
Member
There was a problem hiding this comment.
We need another condition here to avoid the case the same series was scraped as exponential native histogram already.
Member
There was a problem hiding this comment.
We may be able to depend on that the parser always returns native histogram first (p.Next()) and then then the float series of the same, but only if we add some unit tests to make sure.
krajorama
reviewed
Apr 30, 2024
8e6f99b to
7b162bf
Compare
970a0a7 to
6c1ab28
Compare
198577e to
764e137
Compare
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…pend classic histogram series) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
… if they are not actually histograms based on metadata Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Member
|
Reviving in #14978 , I've cherry picked the commits from here to keep credit and history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #13529 and #13532
Assumes that metadata is present as it depends on that to detect classic histogram series for conversion.
Status: Pretty much done except for the exemplar support.