discovery: prevent the manager from storing stale targets #13622
Merged
machine424 merged 1 commit intoprometheus:mainfrom Aug 30, 2024
Merged
discovery: prevent the manager from storing stale targets #13622machine424 merged 1 commit intoprometheus:mainfrom
machine424 merged 1 commit intoprometheus:mainfrom
Conversation
d655774 to
a781458
Compare
roidelapluie
approved these changes
Aug 30, 2024
Member
|
Thanks! |
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
a781458 to
82b53c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12436
needs #13147: merged.
>>>>>>> NOTE:
This fix concerns the SD manager behind the flag
new-service-discovery-managerwhich is the manager used by most third parties but not the one used by default by Prometheus itself, as of now, Prometheus is still using the legacymanagerprometheus/discovery/legacymanager/manager.go
Line 14 in d63f5b3