storage/remote: speed up StoreSeries by re-using labels.Builder#13491
Merged
bboreham merged 2 commits intoprometheus:mainfrom Feb 6, 2024
Merged
storage/remote: speed up StoreSeries by re-using labels.Builder#13491bboreham merged 2 commits intoprometheus:mainfrom
bboreham merged 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Relabeling can take a pre-populated `Builder` instead of making a new one every time. This is much more efficient. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This was referenced Jan 29, 2024
cstyan
approved these changes
Feb 5, 2024
Member
cstyan
left a comment
There was a problem hiding this comment.
LGTM, especially if we're already compiling with the build tag ourselves. The change here shouldn't be blocked on potentially 3rd party impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relabeling can take a pre-populated
Builderinstead of making a newone every time. This is much more efficient.
Added a benchmark to demonstrate:
Also simplify
processExternalLabelstaking advantage ofBuilder.Getadded recently.Switching
processExternalLabelsfromScratchBuildertoBuildermakes the code slower for the no-build-tags implementation oflabels.Labels, which I can fix, but I figured I would wait to see if anyone is affected by this. Prometheus and Grafana Agent are both using-tags stringlabels.