Change metric label for Puppet SD from 'http' to 'puppetdb'#13447
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Jan 26, 2024
Merged
Change metric label for Puppet SD from 'http' to 'puppetdb'#13447roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the metrics for the Puppet SD are not being recorded correctly. They seem to overlap with the metrics of HTTP SD, because Puppet SD uses the same
httplabel.Puppet SD has been using
httpsince #8883, the pull request which originally added the Puppetdb SD.