remote: consider storage.ErrTooOldSample as non-retryable by returning 400#13335
Merged
bboreham merged 1 commit intoprometheus:mainfrom Jan 4, 2024
Merged
remote: consider storage.ErrTooOldSample as non-retryable by returning 400#13335bboreham merged 1 commit intoprometheus:mainfrom
bboreham merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Daniel Kerbel <nmdanny@gmail.com>
LeviHarrison
approved these changes
Dec 31, 2023
Member
|
Ideally you would add a test for this condition, but in the interests of getting it fixed we can do that as a follow-up. |
bboreham
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too old samples now yield 400 instead of 500 errors, when using the out of order feature, to line up with the RW specification regarding retry behavior.
Fixes #13334