Skip to content

ui: Pass unexpected boot errors to StartingContent component#13016

Merged
juliusv merged 1 commit intoprometheus:mainfrom
gillesdemey:gilles/fix-unexpected-error-page
Oct 23, 2023
Merged

ui: Pass unexpected boot errors to StartingContent component#13016
juliusv merged 1 commit intoprometheus:mainfrom
gillesdemey:gilles/fix-unexpected-error-page

Conversation

@gillesdemey
Copy link
Copy Markdown
Contributor

@gillesdemey gillesdemey commented Oct 21, 2023

When an unexpected error occurred during the boot sequence, it was rendering an empty page instead of the progress page with an alert stating something went wrong during initialization.

Signed-off-by: Gilles De Mey <gilles.de.mey@gmail.com>
@gillesdemey gillesdemey requested a review from juliusv as a code owner October 21, 2023 17:03
@juliusv
Copy link
Copy Markdown
Member

juliusv commented Oct 23, 2023

Nice catch, thank you! 👍

@juliusv juliusv merged commit 4912c82 into prometheus:main Oct 23, 2023
@gillesdemey gillesdemey deleted the gilles/fix-unexpected-error-page branch October 23, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants