promtool: Set test group interval default to evaluation interval#13011
Merged
dgl merged 1 commit intoprometheus:mainfrom Oct 20, 2023
Merged
promtool: Set test group interval default to evaluation interval#13011dgl merged 1 commit intoprometheus:mainfrom
dgl merged 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl>
bboreham
approved these changes
Oct 20, 2023
Member
bboreham
left a comment
There was a problem hiding this comment.
Seems reasonable, though I'm not familiar with this area of the code.
Member
|
Thanks, this is what I proposed on the bug. (Somehow the original GitHub email for the PR didn’t make it to me.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
intervalfield fortest_groupis marked as required by the documentation, but the application neither enforces this requirement nor sets a default, leading to a default of 0 and unexpected behavior in some cases. In issue #12871 the idea was proposed to instead make the field optional and setevaluation_intervalas a default if no interval is specified. This may break some existing tests, though these would likewise break if the application started considering an unspecified interval as an error.Fixes #12871