Expose --storage.tsdb.retention.time in metric prometheus_tsdb_retention_limit_seconds#12986
Merged
beorn7 merged 2 commits intoprometheus:mainfrom Oct 24, 2023
Conversation
Signed-off-by: Marcio Caroso <msscaroso@gmail.com>
39ab49d to
a964e03
Compare
Member
|
Thanks for the PR! Given there is already a metric |
…db_retention_limit_seconds Signed-off-by: Marcio Caroso <msscaroso@gmail.com>
Contributor
Author
|
Thank you for reviewing the PR @bboreham. |
bboreham
approved these changes
Oct 19, 2023
Member
bboreham
left a comment
There was a problem hiding this comment.
LGTM; I'll wait for a bit before merging to see if any other maintainers have opinions.
Member
|
Message from the bug scrub: Apparently, no other maintainers have opinions. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the config option
--storage.tsdb.retention.timeas a metric.It's assumed that tsdb.Option is an int64 representing time in milliseconds, based on its definition found here:
prometheus/cmd/prometheus/main.go
Line 1572 in 624b973
Related Issue: #12925