did we update the dependencies?

Was waiting on the go release to do that all in one

Lgtm

/prombench v2.47.2

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-12959 and v2.47.2

After successful deployment, the benchmarking results can be viewed at:

• Prometheus Meta
• Prombench Dashboard
• Grafana Explorer, Loki logs
• Parca profiles (e.g. in-use memory)

Other Commands:
To stop benchmark: /prombench cancel
To restart benchmark: /prombench restart v2.47.2

Note that NewPossibleNonCounterInfo in #12152 makes rate queries inefficient, needs fixing before release.

@zenador Looking at that PR again, that warning looks like something that we should be able to figure out statically when looking at the PromQL, so maybe it can be extracted from the actual function implementation completely? Then it also doesn't have to be evaluated (and the annotation added) for each resolution step of a range query.

Addendum to doing it statically: It wouldn't work in the case where you don't equality-match on the metric name, but at least you could check it once after resolving series identities for selectors, not for each resolution step?

Yes I agree, that particular warning and another one can be derived from the query itself, so we will move it out, but until then, we can remove it for now for a quick fix. However, other warnings do actually look at the data and so those will need to be applied every step.

Some analysis of Prombench on this PR, plus meta-analysis.

I think the problem is clearest in the PromQL timings - it's 10-20% slower:

And once you know what's happening you can see it in memory allocations:

However CPU is unchanged? What gives?

I believe this is because the load-generator is configured to fire queries faster than they can execute, resulting in each Prometheus doing as much work as it can, and the slower one doing less work.
You can just about make that out in the requests/sec (note the y-axis is incorrectly labeled):

Benchmark tests are running for 3 days! If this is intended ignore this message otherwise you can cancel it by commenting: /prombench cancel

Benchmark tests are running for 5 days! If this is intended ignore this message otherwise you can cancel it by commenting: /prombench cancel

/prombench cancel

Benchmark cancel is in progress.