promql: convert QueryOpts to interface#12516
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Jul 4, 2023
vinted:convert_queryopts_to_interface
Merged
promql: convert QueryOpts to interface#12516roidelapluie merged 1 commit intoprometheus:mainfrom vinted:convert_queryopts_to_interface
roidelapluie merged 1 commit intoprometheus:mainfrom
vinted:convert_queryopts_to_interface
Conversation
Convert QueryOpts to an interface so that downstream projects like https://github.com/thanos-community/promql-engine could extend the query options with engine specific options that are not in the original engine. Will be used to enable query analysis per-query. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Contributor
Author
|
CI failure seems unrelated to my changes. |
roidelapluie
approved these changes
Jul 4, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert QueryOpts to an interface so that downstream projects like https://github.com/thanos-community/promql-engine could extend the query options with engine specific options that are not in the original engine.
Will be used to enable query analysis per-query.