scraping: reduce memory allocations on Target labels#12084
Merged
bboreham merged 3 commits intoprometheus:mainfrom Mar 22, 2023
Merged
scraping: reduce memory allocations on Target labels#12084bboreham merged 3 commits intoprometheus:mainfrom
bboreham merged 3 commits intoprometheus:mainfrom
Conversation
This was referenced Mar 8, 2023
beorn7
approved these changes
Mar 12, 2023
Member
beorn7
left a comment
There was a problem hiding this comment.
Very nice. But @roidelapluie should also have a look before merging.
This allows users of a Target to iterate labels without allocating heap memory. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Includes a rewrite of `resolveConflictingExposedLabels` to use `labels.Builder.Get`, which simplifies it considerably. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Since the Target object was just created in this function, nobody else has a reference to it and there are no concerns about it being modified concurrently so we don't need to copy the value. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Member
|
Lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
Target.LabelsRangeallows users of a Target to iterate labels without allocating heap memory.Also, avoid copy of labels for dropped targets in
scrapePool.Sync()- since the Target object was just created in this function, nobody else has a reference to it and there are no concerns about it being modified concurrently so we don't need to copy the value.Includes a rewrite of
resolveConflictingExposedLabelsto uselabels.Builder.Get, which simplifies it considerably.