Skip to content

[RW2] receive: Metadata should not be appended to WAL unless feature flag is used. #17468

@bwplotka

Description

@bwplotka

Metadata WAL records (https://prometheus.io/docs/prometheus/latest/feature_flags/#metadata-wal-records) is still optional and in fact, problematic (#15911)
See:

if _, err = app.UpdateMetadata(ref, ls, m); err != nil {

Noticed during our mentoring call with @pipiland2612 and @saswatamcode

Additionally, this metadata path with scrape loop is omitted, which is probably separate issue -- depending what we do with #17191

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions