Remove obsolete check preventing simultaneous NHCB conversion and created timestamp zero ingestion

In `scrape/manager.go`, there is a check preventing the use of both:

- `ConvertClassicHistogramsToNHCBEnabled`
- `EnableCreatedTimestampZeroIngestion`

https://github.com/prometheus/prometheus/blob/d5cc5e2738e2d0bd80c9ea31ba48fae80613917c/scrape/manager.go#L187-L190


However, the referenced issue [#15137](https://github.com/prometheus/prometheus/issues/15137) is now **closed**, which might mean this limitation might no longer be relevant.  

**Action needed:**
- Verify if the original problem described in #15137 has been resolved.
- If so, **remove this check** to allow simultaneous use of both features.
- Add or update tests to confirm correct behavior when both options are enabled.

	if scrapeConfig.ConvertClassicHistogramsToNHCBEnabled() && m.opts.EnableCreatedTimestampZeroIngestion {
	// TODO(krajorama): fix https://github.com/prometheus/prometheus/issues/15137
	m.logger.Error("error reloading target set", "err", "cannot convert classic histograms to native histograms with custom buckets and ingest created timestamp zero samples at the same time due to https://github.com/prometheus/prometheus/issues/15137")
	continue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove obsolete check preventing simultaneous NHCB conversion and created timestamp zero ingestion #17216

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Remove obsolete check preventing simultaneous NHCB conversion and created timestamp zero ingestion #17216

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions