Conversation
Add new direct use actions to replace the existing style. * Deprecate old action use. * Update dependabot. * Document new usage. * Add CI testing for new actions only. Fixes: #69 Signed-off-by: SuperQ <superq@gmail.com>
4e4d447 to
b1f8a3a
Compare
metalmatze
left a comment
There was a problem hiding this comment.
I saw this earlier but don't know enough about actions. Take my approval with that in mind.
| enable_docker_multibuild: true | ||
| clean-runner-disk: true | ||
| - uses: prometheus/promci-artifacts/restore@f9a587dbc0b2c78a0c54f8ad1cde71ea29a4b76f # v0.1.0 | ||
| - run: ~/go/bin/promu -c ${{ inputs.promu_config}} crossbuild tarballs |
There was a problem hiding this comment.
would not be easier if promu was in the user path so you can call directly promu without knowing it's localisation.
Maybe this is something already in place, or something to change in the github action, wdyt ?
There was a problem hiding this comment.
Good question, this is part is just copying things over from the existing action. Probably a good thing to look into.
| - run: ~/go/bin/promu -c ${{ inputs.promu_config}} crossbuild tarballs | ||
| shell: bash | ||
| - run: ~/go/bin/promu -c ${{ inputs.promu_config}} checksum .tarballs | ||
| shell: bash |
There was a problem hiding this comment.
do you really have to precise which shell you need to use when calling a golang binary ? That should not matter from my opinion
There was a problem hiding this comment.
Yea, not sure why it's that way. It's all the way back from the first commit.
Add new direct use actions to replace the existing style.
Fixes: #69