Skip to content

add sriov, power state and numa node info in PciDevice#748

Merged
SuperQ merged 8 commits intoprometheus:masterfrom
asama-ai:master
Oct 21, 2025
Merged

add sriov, power state and numa node info in PciDevice#748
SuperQ merged 8 commits intoprometheus:masterfrom
asama-ai:master

Conversation

@jj-asama
Copy link
Contributor

@jj-asama jj-asama commented Sep 18, 2025 •
edited
Loading

I found these important for the observability tool I am building. Once this is merged, I will be adding these to the p8s collector as well.
Test case added from a Intel E810 NIC.

	NumaNode        *int32 // /sys/bus/pci/devices/<Location>/numa_node

	SriovDriversAutoprobe *bool   // /sys/bus/pci/devices/<Location>/sriov_drivers_autoprobe
	SriovNumvfs           *uint32 // /sys/bus/pci/devices/<Location>/sriov_numvfs
	SriovOffset           *uint32 // /sys/bus/pci/devices/<Location>/sriov_offset
	SriovStride           *uint32 // /sys/bus/pci/devices/<Location>/sriov_stride
	SriovTotalvfs         *uint32 // /sys/bus/pci/devices/<Location>/sriov_totalvfs
	SriovVfDevice         *uint32 // /sys/bus/pci/devices/<Location>/sriov_vf_device
	SriovVfTotalMsix      *uint64 // /sys/bus/pci/devices/<Location>/sriov_vf_total_msix

	D3coldAllowed *bool          // /sys/bus/pci/devices/<Location>/d3cold_allowed
	PowerState    *PciPowerState // /sys/bus/pci/devices/<Location>/power_state

I am not really interested in Offset, Stride VfDevice and MSI-X. Just added for completeness. Please let me know if I should rather remove them.

@discordianfish for your kind review.

ref: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-bus-pci

@jj-asama
support for sriov, numa and power management config
22dbb89 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
use uint32
679259f 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
adjust bitsize for parseuint
14d7693 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
parseuint for total_msix
511bfcf 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
Merge pull request #1 from asama-ai/sriov
0764bec 
support for sriov, numa and power management config
@jj-asama
revert accidental corruption of fixtures.ttar
04ba3a4 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
fix unintended fixtures changes
2d0acde 
Signed-off-by: root <root@proxmox1.server>
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama jj-asama mentioned this pull request Sep 19, 2025
Merged
SuperQ
SuperQ reviewed Oct 18, 2025
View reviewed changes
sysfs/pci_device.go Outdated

// These files must exist in a device directory.
for _, f := range [...]string{"class", "vendor", "device", "subsystem_vendor", "subsystem_device", "revision"} {
for _, f := range [...]string{"class", "vendor", "device", "subsystem_vendor", "subsystem_device", "revision", "numa_node"} {
Copy link
Member

@SuperQ SuperQ Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure numa_node is always going to exist? Even on older kernels? We tend to support some pretty old kernel versions here.

Copy link
Contributor Author

@jj-asama jj-asama Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 2.6.21 onwards as per
https://kernelnewbies.org/Linux_2_6_21
and
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=81bb0e198b4638ac65233b316f4588639dfe1fcd

But I think I made a mixup here. I used *int32 to make it optional. But added to this list of mandatory files. Will move it out.

Copy link
Member

@SuperQ SuperQ Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking the versions. We used to support 2.6.32, but recently Go changed to >= 3.2.0.

So that works.

SuperQ
SuperQ reviewed Oct 18, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this mostly looks good. Question about the new required file.

@jj-asama
make numa_node optional
699cd6a 
Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama
Copy link
Contributor Author

jj-asama commented Oct 18, 2025

Thanks, this mostly looks good. Question about the new required file.
@SuperQ I have moved it to the other set of optional files.

SuperQ
SuperQ approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit d9d95c9 into prometheus:master Oct 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jj-asama @SuperQ