fix: correct linters-settings typo in .golangci.yml#696
Merged
discordianfish merged 2 commits intoprometheus:masterfrom Feb 3, 2025
Merged
fix: correct linters-settings typo in .golangci.yml#696discordianfish merged 2 commits intoprometheus:masterfrom
discordianfish merged 2 commits intoprometheus:masterfrom
Conversation
The linter configuration had a typo ("linter-settings" instead of
"linters-settings"), which prevented linter rules from being applied.
Fixing this revealed and resolved multiple style issues across the codebase:
- Renamed shadowing parameter in `net_unix.go`
- Fixed import grouping in `valueparser_test.go`
- Corrected comment capitalization and spelling
- Unused parameters
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
discordianfish
approved these changes
Feb 2, 2025
Member
discordianfish
left a comment
There was a problem hiding this comment.
Oops, good catch. Thanks!
Member
|
Looks like there are still issues: |
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Contributor
Author
|
Weird - I'm running latest golangci-lint version locally and it didn't catch this. Ran it on another machine and it did. Oh well, pushed a nolint fix since these refer to a vulnerability name. Should be fine now! |
Member
|
Thanks! |
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linter configuration had a typo ("linter-settings" instead of "linters-settings"), which prevented linter rules from being applied. Fixing this revealed and resolved multiple style issues across the codebase:
net_unix.govalueparser_test.go