infiniband: do not make assumptions about counters based on HCA name#678
Merged
SuperQ merged 2 commits intoprometheus:masterfrom Apr 19, 2025
Merged
infiniband: do not make assumptions about counters based on HCA name#678SuperQ merged 2 commits intoprometheus:masterfrom
SuperQ merged 2 commits intoprometheus:masterfrom
Conversation
Some users have reported cases of systemd "predictable network interface naming" apparently also renaming the HCA device. This means we can no longer make assumptions about which counter(s) should be present based on the HCA name (i.e., irdma*, mlx5_*). The previous approach was quite brittle anyway, since there will undoubtedly be other IB / RoCE drivers in future which implement the hw_counters directory (but not the older counters directory). Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
approved these changes
Apr 19, 2025
Member
|
Sorry, had to fix the commit since I didn't notice this before merging #687. This is a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users have reported cases of systemd "predictable network interface naming" apparently also renaming the HCA device. This means we can no longer make assumptions about which counter(s) should be present based on the HCA name (i.e.,
irdma*,mlx5_*). The previous approach was quite brittle anyway, since there will undoubtedly be other IB / RoCE drivers in future which implement thehw_countersdirectory (but not the oldercountersdirectory).