Enhancement: Implement classes to read drm subsystem#654
Merged
discordianfish merged 2 commits intoprometheus:masterfrom Feb 2, 2025
Merged
Enhancement: Implement classes to read drm subsystem#654discordianfish merged 2 commits intoprometheus:masterfrom
discordianfish merged 2 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Juerg Ritter <jritter@redhat.com>
sysfs/class_drm_card.go
Outdated
|
|
||
| // DrmCard contains info from files in /sys/class/drm for a | ||
| // single DRM Card device. | ||
| type DrmCard struct { |
Member
There was a problem hiding this comment.
Drm -> DRM as of golang naming standard
sysfs/class_drm_card.go
Outdated
| type DrmCardPort struct { | ||
| Name string | ||
| Status string | ||
| Dpms string |
sysfs/class_drm_card.go
Outdated
| @@ -0,0 +1,128 @@ | |||
| // Copyright 2018 The Prometheus Authors | |||
Member
There was a problem hiding this comment.
Update Year (same below)
Signed-off-by: Juerg Ritter <jritter@redhat.com>
Contributor
Author
|
Hi @discordianfish, thanks for your feedback. I've integrated your suggestions into the PR. |
discordianfish
approved these changes
Sep 15, 2024
Member
discordianfish
left a comment
There was a problem hiding this comment.
LGTM, thanks! And sorry for the delay
Contributor
Author
|
Hi, is there a reason why this is not being merged? |
Contributor
Author
|
Hi @SuperQ , is there anything I can do to get this PR merged? |
Contributor
Author
|
Hi, is there an update on this? Would be great to have this merged. Thanks for a feedback. |
Member
|
Thanks for your contribution and sorry again for the delay(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds functionality to read DRM information from the DRM kernel subsystem. This can be useful to get information of GPUs and their ports. As per now, it is possible to get the GPUs with the driver name, and for each of their ports the connection state, enablement state and DPMS state. In the future, it could be enhanced with EDID information, and more GPU driver specific information.