feat(blockdevice): added sysblockdevicesize method and test#650
Closed
fs185143 wants to merge 6 commits intoprometheus:masterfrom
Closed
feat(blockdevice): added sysblockdevicesize method and test#650fs185143 wants to merge 6 commits intoprometheus:masterfrom
fs185143 wants to merge 6 commits intoprometheus:masterfrom
Conversation
Contributor
Author
|
need to add edit: i believe i did this in 8dc60f1 |
dswarbrick
reviewed
Jul 5, 2024
blockdevice/stats.go
Outdated
| if err != nil { | ||
| return 0, err | ||
| } | ||
| return 512 * size, nil |
Member
There was a problem hiding this comment.
Let's make this a const SectorSize
Contributor
Author
|
just following up on this cc @discordianfish |
Contributor
Author
or cc @SuperQ |
Contributor
Author
|
hey could I get a review on this please? any idea who might be best to take a look @dswarbrick |
Contributor
|
@fs185143 You'll have better luck attracting the attention of maintainers if all CI tests are green, plus all commits need to be signed off to comply with the DCO. |
c5589cf to
b0b6389
Compare
Contributor
Author
|
closing in favour of #658 (fixed issues like DCO) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In part to support prometheus/node_exporter#3068, I have added a new method that retrieves the value of
/sys/block/<device>/size