MetricNamer: avoid adding duplicate suffixes when UTF8 is allowed#48
Merged
ArthurSens merged 3 commits intoprometheus:mainfrom Jul 25, 2025
Merged
MetricNamer: avoid adding duplicate suffixes when UTF8 is allowed#48ArthurSens merged 3 commits intoprometheus:mainfrom
ArthurSens merged 3 commits intoprometheus:mainfrom
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
ywwg
reviewed
Jul 23, 2025
ArthurSens
approved these changes
Jul 23, 2025
Member
There was a problem hiding this comment.
Alright, let's pay the 12% CPU penalty 😬
But I was wondering if we could brainstorm a way to not do this. As @ywwg pointed out in #44 (comment), units should not be added to OTel metric names anyway
Contributor
Author
|
Btw, this performance penalty wold only occur if someone is using UTF8Allowed=true and withSuffixes=true, which should be rare (outside of the current Go SDK). |
Signed-off-by: David Ashpole <dashpole@google.com>
Contributor
Author
|
Results are now ~2% better than before thanks to #48 (comment) |
ywwg
reviewed
Jul 23, 2025
Signed-off-by: David Ashpole <dashpole@google.com>
Member
|
Any other concerns @ywwg? We have another release of the collector next Monday, I know it's kinda rushed but it would be nice to have a fix by then |
Member
|
Spoke a bit offline, I'm taking the liberty to merge since we've got a release to do that requires this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
Benchstat:
Adds no allocations or bytes, but adds 10% CPU usage for metrics with a
_totalor_ratiosuffix when UTF8 is allowed and suffixes are added.