Skip to content

chore: add xBSD pipelines#3160

Merged
discordianfish merged 4 commits intoprometheus:masterfrom
rexagod:bsd-pipeline
Feb 4, 2025
Merged

chore: add xBSD pipelines#3160
discordianfish merged 4 commits intoprometheus:masterfrom
rexagod:bsd-pipeline

Conversation

@rexagod
Copy link
Contributor

@rexagod rexagod commented Oct 19, 2024

Run tests on the following GOOS, in addition to Linux:

  • OpenBSD
  • FreeBSD
  • NetBSD
  • Dragonfly
  • Solaris
  • Darwin

The patch also makes changes to the testing scripts and introduces a tools binary to facilitate accommodating for various GOOS OOTB.

Fixes #2883.

@rexagod rexagod changed the title chore: add BSD pipeline [WIP] chore: add BSD pipeline Oct 19, 2024
@rexagod rexagod force-pushed the bsd-pipeline branch 19 times, most recently from 8ce2847 to f2e7601 Compare October 20, 2024 00:00
@discordianfish
Copy link
Member

tests fail

@rexagod rexagod force-pushed the bsd-pipeline branch 9 times, most recently from 6c6bb6c to 17a424d Compare November 23, 2024 04:12
@rexagod rexagod force-pushed the bsd-pipeline branch 14 times, most recently from 84a178a to 7dfafe9 Compare November 24, 2024 19:22
@rexagod
Copy link
Contributor Author

rexagod commented Nov 25, 2024

My bad for excessive force-pushes here, which I later found out could've been (and were) avoided using the "Debug Shell" available here.

Also, it seems OpenBSD workflow needs a bit more debugging.

@rexagod
Copy link
Contributor Author

rexagod commented Nov 26, 2024

Good for reviews now.

cc @discordianfish

For integration tests.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support non-linux GOOS in e2e tests

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support e2e tests on freebsd

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support e2e tests on openbsd

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support e2e tests on netbsd

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support e2e tests on solaris

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: support e2e tests on dragonfly

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

chore: drop support for e2e tests on solaris

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Contributor Author

rexagod commented Dec 21, 2024

Working on adding support for Solaris as well, in addition to accommodating for any newly added metrics since the last time I patched this, to make sure the tests pass.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Contributor Author

rexagod commented Dec 22, 2024

Good for reviews. I've also added Solaris and Darwin. I believe this completes support for all BSD platforms we target in this repository.

cc @discordianfish @SuperQ

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@discordianfish
Copy link
Member

Beside that, this looks really great!

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Contributor Author

rexagod commented Dec 25, 2024

Dropped the changes for Makefile.common from this PR, so that we are not blocked by upstream. Also, this change is not required by GitHub's MacOS runners, so it's safe to merge this PR without that (all checks passing).

I'll pull the changes from upstream once they are merged there, but we can safely proceed independent of them.

@rexagod
Copy link
Contributor Author

rexagod commented Feb 4, 2025

Ping.

@discordianfish
Copy link
Member

Going to merge but @SuperQ please still take a look to be aware etc

@SuperQ
Copy link
Member

SuperQ commented Feb 15, 2025

Hey folks, would you please cleanup the git history before merging changes? Or use the GitHub "squash and merge" function when merging?

It's not great when looking at git changes and seeing a bunch of "fixup fixup fixup" commits. It makes following feature changes difficult (git blame, git show, etc).

@SuperQ SuperQ mentioned this pull request Feb 15, 2025
@discordianfish
Copy link
Member

I did a squash merg for forgot to edit the commit message. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build new *BSD CI pipelines

3 participants