node_scrape_collector_success behaviour #1723
Description
Host operating system: output of uname -a
Linux hostname 3.10.0-1127.8.2.el7.x86_64 #1 SMP Tue May 12 16:57:42 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
node_exporter version: output of node_exporter --version
node_exporter, version 0.18.1 (branch: HEAD, revision: 3db77732e925c08f675d7404a8c46466b2ece83e)
build user: root@b50852a1acba
build date: 20190604-16:41:18
go version: go1.12.5
node_exporter, version 1.0.0 (branch: HEAD, revision: b9c96706a7425383902b6143d097cf6d7cfd1960)
build user: root@3e55cc20ccc0
build date: 20200526-06:01:48
go version: go1.14.3
node_exporter command line flags
none
Are you running node_exporter in Docker?
no
What did you do that produced an error?
Upgrade node_exporter from 0.18.1 to 1.0.0
What did you expect to see?
curl -s localhost:9100/metrics | grep node_scrape_collector_success | grep "0$"
What did you see instead?
curl -s localhost:9100/metrics | grep node_scrape_collector_success | grep "0$"
node_scrape_collector_success{collector="bonding"} 0
node_scrape_collector_success{collector="infiniband"} 0
node_scrape_collector_success{collector="ipvs"} 0
node_scrape_collector_success{collector="nfs"} 0
node_scrape_collector_success{collector="nfsd"} 0
After node_exporter upgrade from 0.18.1 to 1.0.0 multiple collector scrapes are unsuccessful. This specific system does not have bonding, infiniband or nfs, so in theory these scrapes are really not successful. Is this a bug or was this metric value changed to 0 intentionally?
If this was done intentionally, shouldn't other collectors also report 0, as this system does not have ZFS, for example.
Relevant lines from logs:
level=debug ts=2020-05-28T10:00:49.196Z caller=infiniband_linux.go:112 collector=infiniband msg="infiniband statistics not found, skipping"
level=debug ts=2020-05-28T10:00:49.197Z caller=zfs.go:71 collector=zfs err="ZFS / ZFS statistics are not available"
level=debug ts=2020-05-28T10:00:49.200Z caller=nfs_linux.go:99 collector=nfs msg="Not collecting NFS metrics" err="open /proc/net/rpc/nfs: no such file or directory"
level=debug ts=2020-05-28T10:00:49.200Z caller=zfs_linux.go:48 collector=zfs msg="Cannot open file for reading" path=/proc/spl/kstat/zfs/zfetchstats
level=debug ts=2020-05-28T10:00:49.200Z caller=zfs.go:71 collector=zfs err="ZFS / ZFS statistics are not available"
level=debug ts=2020-05-28T10:00:49.200Z caller=zfs_linux.go:48 collector=zfs msg="Cannot open file for reading" path=/proc/spl/kstat/zfs/zil
level=debug ts=2020-05-28T10:00:49.200Z caller=collector.go:159 msg="collector returned no data" name=nfs duration_seconds=3.7687e-05 err="collector returned no data"
level=debug ts=2020-05-28T10:00:49.200Z caller=nfsd_linux.go:65 collector=nfsd msg="Not collecting NFSd metrics" err="open /proc/net/rpc/nfsd: no such file or directory"
level=debug ts=2020-05-28T10:00:49.200Z caller=collector.go:159 msg="collector returned no data" name=nfsd duration_seconds=2.8448e-05 err="collector returned no data"
level=debug ts=2020-05-28T10:00:49.202Z caller=ipvs_linux.go:117 collector=ipvs msg="ipvs collector metrics are not available for this system"