highlight le and quantile label values normalization in Prom 3.0#2572
highlight le and quantile label values normalization in Prom 3.0#2572beorn7 merged 1 commit intoprometheus:mainfrom
Conversation
content/docs/concepts/data_model.md
Outdated
| * Labels with an empty label value are considered equivalent to labels that do not exist. | ||
|
|
||
| NOTE: Beginning with Prometheus v3.0, the values of the `le` label of classic | ||
| histograms and the `quantile` label in summaries are consistently normalized to |
There was a problem hiding this comment.
are invariably? always?
There was a problem hiding this comment.
maybe link the migration guide? https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values
There was a problem hiding this comment.
Not sure if this is a good location for this factoid. The normalization is just an ingestion concern. Non-normalized le and quantile labels still fit the data model (and they even work with PromQL, it's just inconvenient if you have a mix of differently formatted le and quantile labels).
There was a problem hiding this comment.
it was just to give it more visibility, if you provided with le=1 and you ended up with le=1.0, that's the reason.
Removed.
content/docs/concepts/data_model.md
Outdated
| * Labels with an empty label value are considered equivalent to labels that do not exist. | ||
|
|
||
| NOTE: Beginning with Prometheus v3.0, the values of the `le` label of classic | ||
| histograms and the `quantile` label in summaries are consistently normalized to |
There was a problem hiding this comment.
Not sure if this is a good location for this factoid. The normalization is just an ingestion concern. Non-normalized le and quantile labels still fit the data model (and they even work with PromQL, it's just inconvenient if you have a mix of differently formatted le and quantile labels).
| NOTE: Beginning with Prometheus v3.0, the values of the `le` label of classic | ||
| histograms is consistently normalized to a float-like representation upon ingestion. |
There was a problem hiding this comment.
"Float-like representation" is pretty vague. How about this:
| NOTE: Beginning with Prometheus v3.0, the values of the `le` label of classic | |
| histograms is consistently normalized to a float-like representation upon ingestion. | |
| NOTE: Beginning with Prometheus v3.0, the values of the `le` label of classic | |
| histograms are normalized during ingestion to follow the format of [OpenMetrics Canonical Numbers](https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#considerations-canonical-numbers). |
Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: beorn7 <beorn@grafana.com>
As discussed in https://github.com/prometheus/prometheus/pull/15164/files#r1806414216